Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Niteman tweaks (mostly toward Nightmatrons) #790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Niteman tweaks (mostly toward Nightmatrons) #790

wants to merge 1 commit into from
+7 −7

Conversation

OctusGit
Copy link
Contributor

@OctusGit OctusGit commented Sep 25, 2024 •
edited
Loading

About The Pull Request

  • Moves nightman/matrons to nobles, similar to the merchant. Gives them their own flag that doesn't share Jester (Lmao)
  • The nightman leather jacket now works for females, tweaked restrictions on some races that it doesn't look well on.
  • Removed nightman knife skill and their hunting knife. Changed with a coin pouch for holding their funds.

Why It's Good For The Game

Giving the nightman his own flag and actual department flag is just consistent coding and fixing overall incorrect code. Leather jacket is mostly to have a unique clothing item that isn't exactly like the queen's dress. Lastly knife skill is useless and the coin pouch is much more appreciated. They don't really need knife skills when they have level 4 wrestling and unarmed. Their whole focus is hand to hand, knife is garbo.

dreamseeker_IHgUJELo24

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Optimism333
Optimism333 reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Optimism333 Optimism333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly would NOT say knife is garbo, but if you think that a coin pouch would leave them better off, that's quite fine.

Any reason you took aasimar off the allowed race list for the jacket? They can be nitemen/nitematrons as well.

@ThePainkiller
Copy link
Contributor

Know what, you could instead swap knife skill and knife for a cudgel and maces 2. It'd help him more than a pouch of coins tbh.

@NPC1314 NPC1314 added the Merge conflict This PR won't compile due to merge conflics label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Optimism333 Optimism333 Optimism333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Merge conflict This PR won't compile due to merge conflics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OctusGit @ThePainkiller @Optimism333 @NPC1314